inference: add benchmark target to check benefit of method match cache #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This benchmark target corresponds to JuliaLang/julia/pull/46535. `method_match_cache` contains many artificially generated broadcasting operations, that will lead to constant propagations and accompanying method match analysis on call sites with same abstract signatures, e.g. - `Tuple{typeof(convert), Type{Int64}, Int64}` - `Tuple{typeof(convert), Type{Float64}, Float64}` Since we currently don't cache method match result for abstract call signatures on the level of the runtime system, we can obtain the best performance if we cache such abstract method match results on Julia level, that will be revived by JuliaLang/julia/pull/46535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This benchmark target corresponds to JuliaLang/julia/pull/46535.
method_match_cachecontains many artificially generated broadcastingoperations, that will lead to constant propagations and accompanying
method match analysis on call sites with same abstract signatures, e.g.
Tuple{typeof(convert), Type{Int64}, Int64}Tuple{typeof(convert), Type{Float64}, Float64}Since we currently don't cache method match result for abstract call
signatures on the level of the runtime system, we can obtain the best
performance if we cache such abstract method match results on Julia level,
that will be revived by JuliaLang/julia/pull/46535.