Skip to content

Let amend_coverage_from_src! skip partially covered code (WIP) #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Let amend_coverage_from_src! skip partially covered code (WIP) #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Coverage.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,19 @@ module Coverage
flines = function_body_lines(ast)
if !isempty(flines)
flines .+= linestart-1

if any(l -> l > length(coverage), flines)
error("source file is longer than .cov file; source might have changed")
end

# If any line has coverage, assume that Julia executed this code, and
# don't modify any coverage data. This works around issues with inlined
# code, see https://github.com/JuliaCI/Coverage.jl/issues/187
if any(l -> coverage[l] != nothing, flines)
continue
end

for l in flines
if l > length(coverage)
error("source file is longer than .cov file; source might have changed")
end
if coverage[l] === nothing
coverage[l] = 0
end
Expand Down