Remove circular test dependency on StatsBase #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Yep, hist equality is redundant with |
|
Note that CI is green here on nightly and red on master because of Aqua v0.8.14, unrelated to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR removes the circular test dependency on StatsBase. IMO circular dependencies are problematic, even if they are limited to tests, since they make the release process more challenging (see #101).
At first glance, the usefulness of the StatsBase-related test seems dubious as well. If these tests are deemed useful, I think the better approach would be to run downstream tests with the latest release of StatsBase in CI.