Skip to content

Conversation

@ToucheSir
Copy link
Contributor

@ToucheSir ToucheSir commented May 7, 2022

Here's the corresponding PR: JuliaLang/julia#41659.
These methods were pirating the definitions on stable Julia and (among other things) causing precompilation to fail.

These methods were pirating the definitions on stable Julia and (among other things) causing precompilation to fail.
@Roger-luo
Copy link
Collaborator

Thanks!

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #7 (0b68ccf) into master (96d2616) will decrease coverage by 0.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   85.43%   84.63%   -0.81%     
==========================================
  Files           9        9              
  Lines         515      488      -27     
==========================================
- Hits          440      413      -27     
  Misses         75       75              
Impacted Files Coverage Δ
src/patches.jl 70.45% <ø> (ø)
src/ircode.jl 84.37% <0.00%> (-2.81%) ⬇️
src/interp.jl 65.21% <0.00%> (-1.45%) ⬇️
src/utils.jl 82.08% <0.00%> (-1.01%) ⬇️
src/passes.jl 80.74% <0.00%> (-0.69%) ⬇️
src/codeinfo.jl 93.93% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d2616...0b68ccf. Read the comment docs.

@Roger-luo Roger-luo merged commit bde6945 into JuliaCompilerPlugins:master May 8, 2022
@ToucheSir ToucheSir deleted the patch-1 branch May 8, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants