Add ignoreextras feature #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump @quinnj I think @christopher-dG and @fchorney are interested in something like this for use in GitForge.jl. |
|
Hmmm, why didn't CI run on this PR? |
quinnj
added a commit
that referenced
this pull request
Aug 29, 2021
`applyfield` was inconsistent with `applyfield!` in that it threw an error on non-existent fields rather than return `false`, which the docuementation _said_ it did. This fixes `applyfield` to ignore non-existent fieldnames and return `false`. Alternative fix to adding teh `ignoreextras` function proposed in #52.
|
Alternative proposal to just fix |
quinnj
added a commit
that referenced
this pull request
Aug 30, 2021
* Fix applyfield when applied to non-existent fields `applyfield` was inconsistent with `applyfield!` in that it threw an error on non-existent fields rather than return `false`, which the docuementation _said_ it did. This fixes `applyfield` to ignore non-existent fieldnames and return `false`. Alternative fix to adding teh `ignoreextras` function proposed in #52. * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a stopgap for my "do stuff with extra keys" use case, since it's just a lot easier to implement.
Interestingly, the documentation for
applyfieldalready says "returns false whennmisn't a valid field onx", so maybe we should just dohasfield(T, nm) || return falseright at the beginning?