Skip to content

Conversation

@Keno
Copy link
Member

@Keno Keno commented Jul 25, 2024

No description provided.

@Keno Keno requested a review from timholy July 25, 2024 19:52
Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. AFAICT this is not breaking, is that your sense too?

Please address the small comments below and then we can merge. Feel free to do so yourself if you like.

@Keno
Copy link
Member Author

Keno commented Jul 25, 2024

Looks very good. AFAICT this is not breaking, is that your sense too?

Changes the signature of iscallto, but that's internal, so non-breaking.

@Keno Keno merged commit f111efe into master Jul 26, 2024
@Keno
Copy link
Member Author

Keno commented Jul 26, 2024

@timholy Are we good to tag a version with this? If so, which one? 3.0.1 or 3.1?

@timholy timholy deleted the kf/more112 branch July 26, 2024 15:16
@timholy
Copy link
Member

timholy commented Jul 26, 2024

I think it can be just 3.0.1. Should we add #114 to the mix?

@Keno
Copy link
Member Author

Keno commented Jul 26, 2024

Sure, let's do that.

@timholy
Copy link
Member

timholy commented Jul 26, 2024

Great. I'll wait 10min to see if you're partway through making the release, and if it's not been submitted yet I'll do it. Thanks again!

@Keno
Copy link
Member Author

Keno commented Jul 26, 2024

Go for it, I haven't started yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants