Recognize Core.declare_const in get_lhs_rhs #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the minimal change to get Revise working with JuliaLang/julia#57470. Comparison of lowering of `const foo = 1`: 1.11: Expr(:const, :foo), Expr(:(=), :foo, 1) (with edge 2 -> 1) 1.12: Expr(:const, :foo, 1) 1.13: Expr(:call, Core.declare_const, :foo, 1)
|
It looks like this is required after JuliaLang/julia#58187? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #129 +/- ##
===========================================
- Coverage 88.69% 76.86% -11.83%
===========================================
Files 6 6
Lines 1442 1526 +84
===========================================
- Hits 1279 1173 -106
- Misses 163 353 +190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue autocomplete strikes again. That's the one I intended to link. |
|
Thanks @xal-0 !
😆 Will we ever make up our minds?!? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the minimal change to get Revise working with
JuliaLang/julia#57470JuliaLang/julia#58187.Comparison of lowering of
const foo = 1:Expr(:const, :foo), Expr(:(=), :foo, 1)(with edge 2 -> 1)Expr(:const, :foo, 1)Expr(:call, Core.declare_const, :foo, 1)