Skip to content

Conversation

@simeonschaub
Copy link
Member

I think just testing on Linux x64 is probably enough.
fixes #300

@simeonschaub simeonschaub merged commit a8f110e into master Feb 10, 2021
@simeonschaub simeonschaub deleted the sds/nightly_ci branch February 10, 2021 11:50
@nickrobinson251
Copy link
Contributor

Is this going to send us a Slack notification every time the Julia Nightly version fails (when we run CI each night)? We don't want that!

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Feb 10, 2021

given we have

  slack:
    name: Notify Slack Failure
    needs: test
    runs-on: ubuntu-latest

i wonder if we change the Julia Nightly versions to not run on ubuntu-latest (but instead macOS-latest), this means it'd be excluded from notifications?

IDK how GHA works well enough to know. (Maybe @fchorney can advise? Or maybe @oxinabox understand GHA a little better than me?)

@simeonschaub
Copy link
Member Author

Ah, I see, sorry about that! Yes, if that is undesired, I can make it a separate workflow.

@simeonschaub
Copy link
Member Author

i wonder if we change the Julia Nightly versions to not run on ubuntu-latest (but instead macOS-latest), this means it'd be excluded from notifications?

IIUC ubuntu-latest is just the platform the Slack job itself is running on, but it will actually catch all failures on any platform.

@nickrobinson251
Copy link
Contributor

Yeah, since Julia Nightly is unfortunately broken quite regularly (for reasons unrelated to code in this package), we don't want to be notified of failures as that adds too much noise :)

IIUC ubuntu-latest is just the platform the Slack job itself is running on, but it will actually catch all failures on any platform.

Ahh, that makes sense!

Yes, if that is undesired, I can make it a separate workflow.

that'd be great --- thank you!

simeonschaub added a commit that referenced this pull request Feb 10, 2021
oxinabox pushed a commit to JuliaDiff/ChainRulesOverloadGeneration.jl that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we run CI with Julia Nightly Version on PRs?

4 participants