avoid introducing binding for String #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this ensures that we only introduce package-local bindings for values that we define in this package ref JuliaLang/julia#22984
vtjnash
force-pushed
the
jn/eval-global-compat29
branch
from
80b055c to
7dda0f5
Compare
tkelman
reviewed
Aug 1, 2017
| @@ -1,3 +1,3 @@ | |||
| julia 0.5 | |||
| Compat 0.25 | |||
| Compat 0.29 | |||
There was a problem hiding this comment.
this change doesn't seem like a requirement for this package to work
tkelman
reviewed
Aug 1, 2017
|
|
||
| using Compat | ||
|
|
||
| if VERSION < v"0.5.0-dev" |
There was a problem hiding this comment.
this is dead, would be better to delete this branch
|
The whole code block will be removed by #555 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures that we only introduce package-local bindings for values
that we define in this package
ref JuliaLang/julia#22984