more deprecation silencing #657
Conversation
| Base.link_pipe(pipe, julia_only_read = reader_supports_async, julia_only_write = writer_supports_async) | ||
| else | ||
| import Base: link_pipe! | ||
| end |
There was a problem hiding this comment.
I don't think this would be very useful in Compat, so made this local fix here instead.
src/Expanders.jl
Outdated
|
|
||
| function Selectors.runner(::Type{EvalBlocks}, x, page, doc) | ||
| sandbox = Module(:EvalBlockSandbox) | ||
| eval(sandbox, :(import Compat.Markdown)) |
There was a problem hiding this comment.
Not sure, but it silenced a bunch of warnings. I think because previously Markdown was always available by default in all modules since they all have implicit using Base in them.
There was a problem hiding this comment.
WARNING: importing deprecated binding Base.Markdown into EvalBlockSandbox.
WARNING: Base.Markdown is deprecated, run `using Markdown` instead
likely near /home/fredrik/.julia/v0.7/Documenter/test/examples/make.jl:91
There was a problem hiding this comment.
I guess we eval things into the module which references Markdown.
There was a problem hiding this comment.
The errors come from test/examples/src/man/tutorial.md, lines 67-70. I would just add import Compat.Markdown into the @eval block, instead of always importing the Markdown module.
There was a problem hiding this comment.
Ah, good catch, should be fixed now.
src/Documenter.jl
Outdated
| # Prompt user to add public key to github then remove the public key. | ||
| let url = "https://github.com/$user/$repo/settings/keys" | ||
| info("add the public key below to $url with read/write access:") | ||
| @info("add the public key below to $url with read/write access:") |
There was a problem hiding this comment.
These are in a submodule, so needs an import Compat: @info.
fredrikekre
force-pushed
the
fe/deprecations
branch
from
b92bf67 to
dfe7d57
Compare
fredrikekre
force-pushed
the
fe/deprecations
branch
2 times, most recently
from
b1bef6c to
575ea24
Compare
fredrikekre
force-pushed
the
fe/deprecations
branch
from
575ea24 to
18523fe
Compare
needs JuliaLang/Compat.jl#512