Make shader string literals return Shaders #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run into the triangle example failing because shader string literals return tuples and `Program` expects shaders. This fixes it by making the string literals return `Shader`s, which I think makes more sense, and it seems [it used to be that way](https://github.com/JuliaGL/GLAbstraction.jl/pull/66/files#diff-3bcb8e0187346ed182ce51b41e01ee9efda0b7a6185333bb199eb1878fba4798L4). The change could break existing programs if they are using shader string literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run into the triangle example failing because shader string literals return tuples and
Programexpects shaders. This fixes it by making the string literals returnShaders, which I think makes more sense, and it seems it used to be that way. The change could break existing programs if they are using shader string literals.