Skip to content

irgen: Disable fn entry safepoints #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022
+5 −1
Merged

irgen: Disable fn entry safepoints #365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/jlgen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,13 +361,17 @@ function compile_method_instance(@nospecialize(job::CompilerJob),

# set-up the compiler interface
debug_info_kind = llvm_debug_info(job)
params = Base.CodegenParams(;
cgparams = (;
track_allocations = false,
code_coverage = false,
prefer_specsig = true,
gnu_pubnames = false,
debug_info_kind = Cint(debug_info_kind),
lookup = Base.unsafe_convert(Ptr{Nothing}, lookup_cb))
@static if VERSION >= v"1.9.0-DEV.1660"
cgparams = merge(cgparams, (;safepoint_on_entry = false))
Copy link
Member

@vchuravy vchuravy Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, this is not high-priority. But the CPU users like Enzyme would actually want these to be emitted. So it needs to be job-dependent.

end
params = Base.CodegenParams(;cgparams...)

# generate IR
GC.@preserve lookup_cb begin
Expand Down