Added \circ syntax for kernel input transformations #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! I would be supportive for these changes but we cannot have a discrepancy between using TransformedKernel and \circle. |
Member
|
As mentioned in #217 (comment), probably we should reexport |
devmotion
added a commit
that referenced
this pull request
Apr 13, 2021
Member
|
Thanks a lot @kaandocal, I extended your PR in #276 and merged it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented my suggestions re: #217 by extending the \circ syntax to kernel/transformation compositions. For reasons explained in my comment there this behaves differently from
transformfor TransformedKernels in that the order of composition is different so as to preserve associativity.