Skip to content

fix Distances compat #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 13, 2022
Merged

fix Distances compat #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a6e2264
CompatHelper: bump compat for Distances to 0.10 for package test, (ke…
Oct 26, 2021
98815a4
Merge branch 'master' into compathelper/new_version/2021-10-26-00-42-…
st-- Jan 11, 2022
b398577
try out Theo's fix
st-- Jan 11, 2022
f124818
fix test compat
st-- Jan 11, 2022
a7e7452
Merge branch 'master' of github.com:JuliaGaussianProcesses/KernelFunc…
st-- Jan 12, 2022
01530b6
use ForwardDiff for chain rule test of SqMahalanobis
st-- Jan 12, 2022
740dcb5
test on 1.4 instead of 1.3 - see if the chainrules test passes there
st-- Jan 12, 2022
733cfcc
revert version branch
st-- Jan 12, 2022
f692b4d
revert to 1.3
st-- Jan 13, 2022
ae34ff2
test_broken for older Julia versions
st-- Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/chainrules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function ChainRulesCore.rrule(s::Sinus, x::AbstractVector, y::AbstractVector)
return val, evaluate_pullback
end

## Reverse Rulse SqMahalanobis
## Reverse Rules SqMahalanobis

function ChainRulesCore.rrule(
dist::Distances.SqMahalanobis, a::AbstractVector, b::AbstractVector
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
[compat]
AxisArrays = "0.4.3"
Compat = "3"
Distances = "= 0.10.0, = 0.10.1, = 0.10.2, = 0.10.3, = 0.10.4"
Distances = "0.10"
Documenter = "0.25, 0.26, 0.27"
FiniteDifferences = "0.10.8, 0.11, 0.12"
ForwardDiff = "0.10"
Expand Down
8 changes: 6 additions & 2 deletions test/chainrules.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
compare_gradient(:Zygote, [x, y]) do xy
KernelFunctions.Sinus(r)(xy[1], xy[2])
end
compare_gradient(:Zygote, [Q, x, y]) do xy
SqMahalanobis(xy[1])(xy[2], xy[3])
if VERSION < v"1.6"
Copy link
Member

@devmotion devmotion Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this check?

Copy link
Member Author

@st-- st-- Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seemed to pass fine as is on 1.6, and I don't want to skip checks if I can avoid it.

Copy link
Member

@devmotion devmotion Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but how is the Julia version relevant here? It does not affect the version of Distances that is used, so why can't we use the same test for all Julia versions? It also seems tests fail on Julia 1.3 currently.

Copy link
Member Author

@st-- st-- Jan 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant because it only fails in 1.3 (and 1.4). It passes with 1.6 and 1.7. [not tested on 1.5]

Should we just skip the test for 1.3? Or raise julia compat to 1.4 (part of Ubuntu 20.04) or 1.6 (LTS)?

@test_broken "Chain rule of SqMahalanobis is broken in Julia pre-1.6"
else
compare_gradient(:Zygote, [Q, x, y]) do Qxy
SqMahalanobis(Qxy[1])(Qxy[2], Qxy[3])
end
end
end