Skip to content

Conversation

@bjarthur
Copy link
Member

see discussion here

@bjarthur
Copy link
Member Author

the tests won't pass until JuliaMath/FixedPointNumbers.jl#61 is merged and tagged.

@tlnagy
Copy link
Member

tlnagy commented Jan 24, 2017

Can you close/open this to restart the tests? JuliaMath/FixedPointNumbers.jl#61 has merged so they should pass.

@timholy timholy closed this Jan 24, 2017
@timholy timholy reopened this Jan 24, 2017
@bjarthur
Copy link
Member Author

fixedpointnumbers needs to be tagged as well for this PR to work. given that 61 is the only commit since the last tag, it might not make sense to do so yet.

@tlnagy
Copy link
Member

tlnagy commented Jan 25, 2017

Once JuliaMath/FixedPointNumbers.jl#62 is merged, we could probably tag a new release.

@codecov-io
Copy link

codecov-io commented Jan 31, 2017

Codecov Report

Merging #62 into master will increase coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   64.68%   64.81%   +0.13%     
==========================================
  Files           1        1              
  Lines         269      270       +1     
==========================================
+ Hits          174      175       +1     
  Misses         95       95
Impacted Files Coverage Δ
src/ColorVectorSpace.jl 64.81% <100%> (+0.13%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9b086d...e2584b5. Read the comment docs.

@bjarthur
Copy link
Member Author

bjarthur commented Feb 8, 2017

running tests since JuliaMath/FixedPointNumbers.jl#61 is tagged

@bjarthur
Copy link
Member Author

bjarthur commented Feb 9, 2017

tests are passing. will merge in a couple days unless someone has an objection.

test/runtests.jl Outdated

@testset "typemin/max" begin
for T in (Normed{UInt8,8}, Normed{UInt8,6}, Normed{UInt16,16}, Normed{UInt16,14}, Float32, Float64)
@test typemin(Gray{T}) == typemin(T)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be best to test with ===, e.g., typemin(Gray{T}) === Gray{T}(typemin(T)) or something. Otherwise I don't think we're testing that typemin(T) returns a value of type T.

@bjarthur
Copy link
Member Author

changed to ===. tests pass so i'll merge in a couple days unless someone voices further concerns.

@timholy timholy merged commit 2449575 into JuliaGraphics:master Feb 15, 2017
@timholy
Copy link
Member

timholy commented Feb 15, 2017

Thanks!

@bjarthur bjarthur deleted the bja/typeminmax branch April 23, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants