-
Notifications
You must be signed in to change notification settings - Fork 23
added typemin/max for AbstractGray #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
the tests won't pass until JuliaMath/FixedPointNumbers.jl#61 is merged and tagged. |
|
Can you close/open this to restart the tests? JuliaMath/FixedPointNumbers.jl#61 has merged so they should pass. |
|
fixedpointnumbers needs to be tagged as well for this PR to work. given that 61 is the only commit since the last tag, it might not make sense to do so yet. |
|
Once JuliaMath/FixedPointNumbers.jl#62 is merged, we could probably tag a new release. |
d6daea6 to
d6c8d42
Compare
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
+ Coverage 64.68% 64.81% +0.13%
==========================================
Files 1 1
Lines 269 270 +1
==========================================
+ Hits 174 175 +1
Misses 95 95
Continue to review full report at Codecov.
|
d6c8d42 to
0fe199c
Compare
|
running tests since JuliaMath/FixedPointNumbers.jl#61 is tagged |
0fe199c to
f342457
Compare
|
tests are passing. will merge in a couple days unless someone has an objection. |
test/runtests.jl
Outdated
|
|
||
| @testset "typemin/max" begin | ||
| for T in (Normed{UInt8,8}, Normed{UInt8,6}, Normed{UInt16,16}, Normed{UInt16,14}, Float32, Float64) | ||
| @test typemin(Gray{T}) == typemin(T) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be best to test with ===, e.g., typemin(Gray{T}) === Gray{T}(typemin(T)) or something. Otherwise I don't think we're testing that typemin(T) returns a value of type T.
f342457 to
e2584b5
Compare
|
changed to |
|
Thanks! |
see discussion here