ERROR: UndefVarError: `rm_singleton_indices` not defined in Julia 1.10

[lazarusA]

Getting this in Julia 1.10

julia> ds_skip_cube[Variables=At(["SNDPPT_M_sl1_250m_llnor"])]
ERROR: UndefVarError: `rm_singleton_indices` not defined

which is defined here:

DiskArrays.jl/src/subarray.jl

Line 64 in 716f509

J′ = Base.rm_singleton_indices(ntuple(Returns(true), Val(ndims(A))), J...)

BUT, I don't even see this being available in Base for Julia 1.10, it is in Julia 1.11 though.

[felixcremer]

This function was introduced into main in JuliaLang/julia#53228 but was then also backported to 1.10 and should therefore be available since 1.10.2.
On which exact version are you?

But this is a dependency on an internal Base function. Is this necessary or could we try to refactor it to only depend on public functions.

[rafaqz]

Ahh we needed to minimum bound to 1.10.2 but too late for that now. Its only a few lines if we just want to duplicate it here.

[lazarusA]

indeed, I was running it on 1.10.0

[rafaqz]

Should we still fix it or just tell people to update?

[lazarusA]

updating works, but it really comes as a surprise if you are running this in a version that is supposed to be supported. Locally I can always use my own version 😄 , but in HPC systems I always need to wait for a ticket to get resolved 😆 and then get the latest lts Julia. Not sure what would be easiest way forward, maybe just tell users to update 😉!

[rafaqz]

Ok lets just copy paste those three lines from Base to here so it doesn't happen on HPC