Support reading AbstractArray #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The tests for writing AbstractArray are https://github.com/JuliaIO/HDF5.jl/pull/520/files#diff-cb8a736be11ad8e4c992aa7427b04339R416 Is there a way to we can add a test for this just in case? |
Contributor
|
If I read the code correctly, this at least need a check as good as #523 (that check isn't complete but this should have at least that). |
Member
|
@yuyichao is the check good enough for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by JuliaIO/MAT.jl#86 to allow the use of
reinterpreted arrays as buffers. I'm not at all familiar with this code base, so I don't know if/what any tests for this should look like.