Compatibility for Julia v 1.0.1 #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
requested changes
Oct 29, 2018
Collaborator
yuyichao
left a comment
yuyichao
left a comment
There was a problem hiding this comment.
Still dup of #86 but if you make sure you don't touch the copying related ones, fix all the comments below, this can be merged if you claim that it fixes some usecases.
You do need to raise the julia requirement to at least 0.6.
src/MAT.jl
Outdated
| to a Matlab file, opening and closing it automatically. | ||
| """ | ||
| function matwrite{S, T}(filename::AbstractString, dict::Associative{S, T}) | ||
| function matwrite(filename::AbstractString, dict::Dict{S, T}) where{S,T} |
| mattype = a_read(dset, name_type_attr_matlab) | ||
| if mattype == "char" | ||
| return "" | ||
| elseif mattype == "struct" |
src/MAT_HDF5.jl
Outdated
|
|
||
| # Write the MATLAB type string for dset | ||
| m_writetypeattr{T}(dset, ::Type{Complex{T}}) = m_writetypeattr(dset, T) | ||
| m_writetypeattr(dset, ::Type{Complex{T}}) where{T} = m_writetypeattr(dset, T) |
src/MAT_HDF5.jl
Outdated
|
|
||
| # Write Associative as a struct | ||
| m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, s::Associative) = | ||
| m_write(mfile::MatlabHDF5File, parent::HDF5Parent, name::String, s::Dict) = |
src/MAT.jl
Outdated
|
|
||
| # Check for MAT v4 file | ||
| magic = read!(rawfid, Vector{UInt8}(4)) | ||
| magic = read!(rawfid, Vector{UInt8}(undef,4)) |
Collaborator
There was a problem hiding this comment.
Space after the ,, same below.
Collaborator
|
And this shouldn't drop 0.6 support so you need |
Collaborator
|
Sorry I made a mistake when updating this branch (I pushed my local master instead of the updated branch to the PR branch) and it appears not revertable so I reopenned this as #102 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly rewrote :
some functions definitions with the new syntax ' func(... : : T) where{T}'.
struct definitions with the keyword 'struct' instead of 'type'
old variables Vector{UInt8}(nbytes) to Vector{UInt8}(undef,nbytes)
After these modifications i was able to read some .mat files