Compat.isapprox method with nans keyword argument #309
Conversation
src/Compat.jl
Outdated
| export ≈, ≉ | ||
| end | ||
| if VERSION < v"0.6.0-dev.2093" # Compat.isapprox to allow for NaNs | ||
| if VERSION >= v"0.4.0-dev+6578" |
There was a problem hiding this comment.
We require julia 0.4, so this should always be true?
There was a problem hiding this comment.
Thanks. Then I might as well just remove the previous definition as part of this PR.
andreasnoack
force-pushed
the
anj/compat
branch
from
6af46c9 to
9ea34db
Compare
|
|
||
| if VERSION < v"0.6.0-dev.2093" # Compat.isapprox to allow for NaNs | ||
| using Base.rtoldefault | ||
| function isapprox(x::Number, y::Number; rtol::Real=rtoldefault(x,y), atol::Real=0, nans::Bool=false) |
There was a problem hiding this comment.
don't want to overwrite the default when nans is not specified, right?
There was a problem hiding this comment.
Yes. That was the plan.
There was a problem hiding this comment.
is it possible to define a kwarg method without a default value?
There was a problem hiding this comment.
Nope, that's a syntax error saying that the kwarg needs a default value.
There was a problem hiding this comment.
Let me phrase the original question differently then. Doesn't the default-value method here overwrite the base method without the nan kwarg?
There was a problem hiding this comment.
I'm not importing the Base method so I wouldn't think so.
|
Can we merge this? The tests are failing because of the |
* Remove `take!(::Task)` definition for Julia versions prior to 0.6 Was added in #307. * Remove `redirect_std*(f, stream)` definitions for Julia prior to v0.6 Were added in #275. * Remove at-__DIR__ macro definition for Julia versions prior to 0.6 Was added in #281. * Remove `broadcast` definition for equal-length tuples Was added in #324 and #328 * Remove definitions of `unsafe_get` and `isnull` fallsback Were added in #287. * Remove defintions of `xor` and `⊻` Were added in #289. * Definitions of `numerator` and `denominator` Were added in #290. * Remove defintion of `iszero` Was added in #305. * Remove definition of `>:` Was added in #336 * Remove definition of `take!(::Base.AbstractIOBuffer)` Was added in #290. * Remove definiton of `.&` and `.|` Were added in #306. * Remove definition of `Compat.isapprox` Was added in #309.
5 participants
No description provided.