Clean up fixed world age mechanism to use closures #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 96.78% 96.72% -0.07%
==========================================
Files 14 14
Lines 4080 4086 +6
==========================================
+ Hits 3949 3952 +3
- Misses 131 134 +3
|
Using a closure here to hold the fixed world age seems nicer than a global within the JuliaSyntax module.
c42f
force-pushed
the
c42f/freeze-world-cleanup
branch
from
3548a31 to
22ddba4
Compare
c42f
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 17, 2025
…ntax.jl#290) Using a closure here to hold the fixed world age seems nicer than a global within the JuliaSyntax module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a closure here to hold the fixed world age seems nicer than a global within the JuliaSyntax module.