Delete unused down option from parse_docstring #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 95.97% 93.03% -2.95%
==========================================
Files 14 14
Lines 4196 3989 -207
==========================================
- Hits 4027 3711 -316
- Misses 169 278 +109 ☔ View full report in Codecov by Sentry. |
c42f
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an NFC simplification of control flow.
After this merges, I plan to follow up with swapping the order of parse_public and parse_docstring and then adjusting the quote callsites of parse_eq to be parse_public. That should fix - JuliaLang/julia#51450 without allowing docstrings in quotes. (or, if we'd like, we can also allow docstrings in quotes)