Skip to content

Conversation

@dkarrasch
Copy link
Member

This method can only be reached with complex eltypes, and after promotion of alpha and beta, they cannot be Bool anymore. Also, this adds 5-arg mul! of which I'm not sure we had some (even though coverage said it was covered, which is strange because it shouldn't due to the issue fixed in #1247).

@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (e64a3df) to head (39588e0).
Report is 34 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1254   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          34       34           
  Lines       15459    15460    +1     
=======================================
+ Hits        14221    14222    +1     
  Misses       1238     1238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit e65e75c into master Apr 13, 2025
4 checks passed
@jishnub jishnub deleted the dk/herk_wrapper branch April 13, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants