Skip to content

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Sep 7, 2023

Fixes the issue observed in JuliaLang/julia#51046 (comment)

Downloads.jl uses a precompilation statement and we bake into the system image a temporary filename
that only exists during precompilation.

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #31 (a373162) into master (976e51a) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   95.34%   95.52%   +0.17%     
==========================================
  Files           4        4              
  Lines         129      134       +5     
==========================================
+ Hits          123      128       +5     
  Misses          6        6              
Files Changed Coverage Δ
src/ssh_options.jl 100.00% <100.00%> (ø)

📢 Have feedback on the report? Share it here.

@StefanKarpinski StefanKarpinski merged commit aab83e5 into master Sep 7, 2023
@StefanKarpinski StefanKarpinski deleted the vc/reset_bundled_known_hosts_file branch September 7, 2023 22:11
@StefanKarpinski
Copy link
Member

Good find!

@DilumAluthge
Copy link
Member

Thanks Valentin and Stefan!

This will be included in JuliaLang/julia#51237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants