-
-
Notifications
You must be signed in to change notification settings - Fork 197
update Windows compilers #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
update Windows compilers #1012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00b3d13
to
530576f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1012 +/- ##
=======================================
Coverage 86.23% 86.23%
=======================================
Files 3 3
Lines 799 799
=======================================
Hits 689 689
Misses 110 110 ☔ View full report in Codecov by Sentry. |
The previous compilers were also repackaged (also by me) so I think this is fine. |
topolarity
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 3, 2025
…50874)" This reverts commit eb4416b. As of LLVM 16, we automatically emit: .drectve `-exclude-symbols:"<symbol>"` which mitigates this issue where it is supported by the linker (which is the case for at least GCC 11+ and LLD 14+). PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+
topolarity
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 3, 2025
…50874)" This reverts commit eb4416b. As of LLVM 16, we automatically emit: .drectve `-exclude-symbols:"<symbol>"` which mitigates this issue where it is supported by the linker (which is the case for at least GCC 11+ and LLD 14+). PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+
topolarity
added a commit
to JuliaLang/julia
that referenced
this pull request
Oct 7, 2025
…50874)" (#59736) This reverts commit eb4416b. As of LLVM 16, we automatically emit: ``` .drectve `-exclude-symbols:"<symbol>"` ``` which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working) PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Oct 10, 2025
…50874)" (#59736) This reverts commit eb4416b. As of LLVM 16, we automatically emit: ``` .drectve `-exclude-symbols:"<symbol>"` ``` which mitigates this issue where it is supported by the linker (GCC 11+ and LLD 14+ are tested working) PackageCompiler on Windows now ships GCC 14 (JuliaLang/PackageCompiler.jl#1012), so we should no longer need this workaround that can make a 15-minute sysimage compilation take an hour+ (cherry picked from commit 1cba9c2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better to link to an official URL but those are in 7z format and Artifacts require .tar.gz so I had to repack it (similar to what was earlier done).
Fixes #918