Allow configuring can_fancyprint(io::IO) using IOContext #4042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I see that this function was moved/copied to Base in JuliaLang/julia#53403, so I would make a matching PR there. But I'll wait for feedback here before I continue :) |
|
Makes sense to me, and yeah needs opening against the julia repo now. |
|
@IanButterworth Moved to JuliaLang/julia#58887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR adds the ability to override
can_fancyprint(io::IO)for a self-provided IO by setting an IOContext flag::Pkg_force_fancyprintcan be set to true or false.Why
My use case is Pluto, where we call Pkg functions like
Pkg.precompile()with a buffer asio. Our display (in the browser) supports fancy-printing, but because the buffer is not a<: Base.TTY, Pkg will not fancy-print.The current workaround in Pluto is to add type piracy to the
Pkg.can_fancyprintfunction, defining a new, more specific method forcan_fancyprint(io::IOContext{BufferStream})where we set it totrue, but I want to avoid this solution.What do you think?