Fix use of reexport inside of baremodules #33
Conversation
As described in issue 32, the generated code from the macro included references to `Base`, which notably is not defined in `baremodule`s. We can get around this by moving the part that fetches and filters module names into its own function, ensure that gets used as a `GlobalRef` by the macro, and swap the `eval` for `Core.eval`, which is available in `baremodule`s.
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 20 24 +4
=========================================
+ Hits 20 24 +4
Continue to review full report at Codecov.
|
|
Hey! I have no idea why, but this PR seems to have broken a bunch of packages. We're currently experiencing the following error in Turing.jl: ulia> using Turing
[ Info: Precompiling Turing [fce5fe82-541a-59a6-adf8-730c64b5f9a0]
ERROR: LoadError: LoadError: cannot assign a value to variable Core.Core from module Turing
Stacktrace:
[1] include(mod::Module, _path::String)
@ Base ./Base.jl:386
[2] include(x::String)
@ Turing ~/Projects/public/Turing.jl/src/Turing.jl:1
[3] top-level scope
@ ~/Projects/public/Turing.jl/src/Turing.jl:33
[4] include
@ ./Base.jl:386 [inlined]
[5] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
@ Base ./loading.jl:1235
[6] top-level scope
@ none:1
[7] eval
@ ./boot.jl:360 [inlined]
[8] eval(x::Expr)
@ Base.MainInclude ./client.jl:446
[9] top-level scope
@ none:1which is fixed by restricting to |
|
Ah I assume the problem is that the module in Turing is called |
|
Yeah I figured too, but this is not disallowed, right? |
|
Really sorry, folks! Reexport v1.2.2 has been released which I've confirmed works with Turing. I'm also yanking Reexport v1.2.1 from the registry. |
4 participants
As described in #32, the generated code from the macro included references to
Base, which notably is not defined inbaremodules. We can get around this by moving the part that fetches and filters module names into its own function, ensure that gets used as aGlobalRefby the macro, and swap theevalforCore.eval, which is available inbaremodules.Fixes #32.