vcat of matrices should not be in SparseArrays.jl

[dlfivefifty]

This feels like type piracy:

julia> @which vcat(randn(2,10), randn(2,10))
vcat(A::Union{Array{T,1}, Array{T,2}, Adjoint{T,Array{T,1}}, RowVector{T,Array{T,1}}, Transpose{T,Array{T,1}}, LinearAlgebra.AbstractTriangular{T,A} where A<:(Array{T,2} where T), Hermitian{T,A} where A<:(Array{T,2} where T), Symmetric{T,A} where A<:(Array{T,2} where T)}...) where T in SparseArrays at /Users/solver/Projects/julia7/usr/share/julia/stdlib/v0.7/SparseArrays/src/sparsevector.jl:1068

julia> @which hcat(randn(2,10), randn(2,10))
hcat(A::Union{Array{T,1}, Array{T,2}, Adjoint{T,Array{T,1}}, RowVector{T,Array{T,1}}, Transpose{T,Array{T,1}}, LinearAlgebra.AbstractTriangular{T,A} where A<:(Array{T,2} where T), Hermitian{T,A} where A<:(Array{T,2} where T), Symmetric{T,A} where A<:(Array{T,2} where T)}...) where T in SparseArrays at /Users/solver/Projects/julia7/usr/share/julia/stdlib/v0.7/SparseArrays/src/sparsevector.jl:1069

Note that the special case of vector is in Base:

 julia> @which vcat(randn(10), randn(10))
vcat(arrays::Array{T,1}...) where T in Base at array.jl:1532

[KristofferC]

type piracy

Well, rand(2,2) * rand(2)?

[dlfivefifty]

Type piracy was not the right word... but it's a bit silly since the sparse array function immediately calls Base.typed_vcat. And why would vcat of vectors be in base but not vcat of matrices?

[Sacha0]

The present code organization is an artifact of hacking around the lack of a proper concatenation promotion system; it should indeed change one day :). Best!

[laborg]

This has been fixed in #43127 :

julia> @which vcat(randn(2,10), randn(2,10))
vcat(A::Union{Vector{T}, Matrix{T}, LinearAlgebra.Adjoint{T, Vector{T}}, LinearAlgebra.Transpose{T, Vector{T}}, LinearAlgebra.AbstractTriangular{T, A} where A<:(Matrix), LinearAlgebra.Hermitian{T, A} where A<:(Matrix), LinearAlgebra.Symmetric{T, A} where A<:(Matrix)}...) where T in LinearAlgebra at /home/aigner/code/julia/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/special.jl:376

julia> @which hcat(randn(2,10), randn(2,10))
hcat(A::Union{Vector{T}, Matrix{T}, LinearAlgebra.Adjoint{T, Vector{T}}, LinearAlgebra.Transpose{T, Vector{T}}, LinearAlgebra.AbstractTriangular{T, A} where A<:(Matrix), LinearAlgebra.Hermitian{T, A} where A<:(Matrix), LinearAlgebra.Symmetric{T, A} where A<:(Matrix)}...) where T in LinearAlgebra at /home/aigner/code/julia/usr/share/julia/stdlib/v1.8/LinearAlgebra/src/special.jl:377