Minor tweaks to https://github.com/JuliaLang/julia/pull/19791 #19798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so type argument does not have to be <:Integer example: round(Float32, rand(1:5,5,5) .// rand(1:5,5,5))
was previously defined for AbstractSparseVector, and there was a typo that was giving a method redefinition warning because Sparse should have been Strided fix ambiguity
Sacha0
approved these changes
Dec 31, 2016
Member
Sacha0
left a comment
Sacha0
left a comment
There was a problem hiding this comment.
LGTM. Thanks for patching these methods!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit messages:
Loosen deprecations for vectorized round, trunc, floor, ceil
so type argument does not have to be
<:Integerexample:
round(Float32, rand(1:5,5,5) .// rand(1:5,5,5))Loosen and fix up the min, max specialization on SparseVectors
was previously defined for AbstractSparseVector, and
there was a typo that was giving a method redefinition warning
because Sparse should have been Strided