remove some links to Nullable and methods #19961
Conversation
I find it distracting that every word `Nullable` and every method associated is a link. The link should appear only the first time the new method is mentioned.
nalimilan
added
missing data
|
@mzaffalon could you add the link in the first paragraph of the Nullable types section? Here would probably be the appropriate place:
|
doc/src/manual/types.md
Outdated
| object, getting a result that is missing if either the `Nullable` | ||
| itself was missing, or the test failed. | ||
| * Perform general operations on single or multiple [`Nullable`](@ref) | ||
| * Perform general operations on single or multiple `Nullable` |
There was a problem hiding this comment.
Remove the words or multiple here; I believe they were left over from #19787.
doc/src/manual/types.md
Outdated
| higher-order function is [`broadcast`](@ref), which can handle a wide variety of cases. | ||
|
|
||
| [`broadcast`](@ref) can be thought of as a way to make existing operations work | ||
| `broadcast` can be thought of as a way to make existing operations work |
There was a problem hiding this comment.
Remove "multiple data" mention here.
There was a problem hiding this comment.
You mean "broadcast can be thought of as a way to make existing operations work simultaneously and propagate nulls"? Can you please confirm the sentence has a meaning?
There was a problem hiding this comment.
Perhaps "make existing operations work on Nullable arguments and propagate nulls"?
There was a problem hiding this comment.
@TotalVerb can you please check whether the change is OK? Otherwise feel free to edit it.
comment about broadcast on `Nullable`
StefanKarpinski
left a comment
StefanKarpinski
left a comment
There was a problem hiding this comment.
Yes, only the first reference to something in a section (chapter, whatever is a reasonable unit of text) should be a link to the definition.
|
Can this PR be merged? |
|
Yep, thanks for the reminder |
7 participants
I find it distracting that every word
Nullableand every method associated is a link.The link should appear only the first time a new method is mentioned.