Skip to content

Rename IntSet to PositiveIntSet #20512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Rename IntSet to PositiveIntSet #20512

wants to merge 1 commit into from

Conversation

@mbauman
Copy link
Member

@mbauman mbauman commented Feb 8, 2017

Following #20456 this is a better and more accurate name.

@mbauman
Rename IntSet to PositiveIntSet
800fc2e 
Following #20456 this is a better and more accurate name.
@JeffBezanson
Copy link
Member

JeffBezanson commented Feb 8, 2017

I think this name is overly pedantic. BitSet might be ok, I think some languages use that.

@tkelman tkelman added the deprecation This change introduces or involves a deprecation label Feb 8, 2017
@ararslan ararslan added the collections Data structures holding multiple items, e.g. sets label Feb 8, 2017
@StefanKarpinski
Copy link
Member

StefanKarpinski commented Feb 8, 2017

For what it's worth, IntSet has 280k Google hits; BitSet has 6.6m Google hits.

@mbauman
Copy link
Member Author

mbauman commented Feb 26, 2017

I don't feel strongly enough about these names to push a rename through at this stage.

@mbauman mbauman closed this Feb 26, 2017
@tkelman tkelman deleted the mb/positiveintset branch February 27, 2017 06:15
@Sacha0 Sacha0 mentioned this pull request Oct 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

collections Data structures holding multiple items, e.g. sets deprecation This change introduces or involves a deprecation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mbauman @JeffBezanson @StefanKarpinski @tkelman @ararslan