Skip to content

Fix printing of indices in the depwarn for to_indexes #20960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2017
Merged

Fix printing of indices in the depwarn for to_indexes #20960

merged 1 commit into from
Mar 10, 2017

Conversation

@timholy
Copy link
Member

@timholy timholy commented Mar 9, 2017

Currently our depwarn prints in a confusing manner:

julia> Base.to_indexes(1, 2:3)
WARNING: to_indexes is deprecated; pass both the source array `A` and indices as `to_indices(A, 12:3)` instead.
Stacktrace:
...

Now this yields:

julia> Base.to_indexes(1, 2:3)
WARNING: to_indexes is deprecated; pass both the source array `A` and indices as `to_indices(A, 1, 2:3)` instead.
Stacktrace:

@kshyatt kshyatt added deprecation This change introduces or involves a deprecation display and printing Aesthetics and correctness of printed representations of objects. labels Mar 9, 2017
@KristofferC KristofferC merged commit 3b5a0eb into master Mar 10, 2017
@p-zubieta p-zubieta deleted the teh/depwarn_printing_to_indexes branch March 10, 2017 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ararslan ararslan ararslan approved these changes

+1 more reviewer

@tkelman tkelman tkelman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deprecation This change introduces or involves a deprecation display and printing Aesthetics and correctness of printed representations of objects.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@timholy @tkelman @ararslan @kshyatt @KristofferC