-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
RFC, IANAL: clarify some license special cases #21048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FFTW wrappers were moved and mostly rewritten - the Julia wrappers are probably not GPL? ref 481f351 and #8248 and #12201 make note of grisu derived license in top-level LICENSE.md and update links, repo was moved from github.com/floitsch to github.com/google umfpack and cholmod code were moved from base/linalg to base/sparse
3d1344e to
5407287
Compare
|
@tkelman, I don't think the wrapper functions by themselves would constitute a derived work (but IANAL, obviously). Even if they were a derived work they would presumably be derived from the The combination of the wrappers (and any code calling the wrappers) and the FFTW library, i.e. software actually using FFTW via the wrappers, would be a derived work and subject to the GPL, of course. |
|
Thanks! Useful that the header is BSD-2, was not aware of that. What I'm partially working towards here is getting |
|
FYI, the |
|
(since Jeff added that line) |
|
|
||
| The following components of Julia's standard library have separate licenses: | ||
|
|
||
| - base/fftw.jl (see [FFTW](http://fftw.org/doc/License-and-Copyright.html)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @JeffBezanson thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file itself is not and never has been GPL – it's MIT like the rest of Julia. So: ✔️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it should still say something about the FFTW dependency if you call the fft etc. routines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably covered by the "Julia's standard library uses the following external libraries" bullet above, same as for the rest of the ccall dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want positive confirmation from Jeff on this, rather than implicit silence, since he originally wrote this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is ok.
FFTW wrappers were moved and mostly rewritten since the line about base/fftw.jl in LICENSE.md was added - ref 481f351 and #8248 and #12201 - @stevengj what are your thoughts on whether the ccall wrapper functions would be considered a derived work, do you think the the Julia wrappers are GPL or not?
Also add mentions of base/grisu and src/support/strtod.c to the top-level license file.