Skip to content

Add a missing return in doInitialization #21913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2017
Merged

Add a missing return in doInitialization #21913

merged 1 commit into from
May 16, 2017

Conversation

@ararslan
Copy link
Member

@ararslan ararslan commented May 16, 2017

This fixes the warning emitted by Clang when building, and it fixes the segfault that occurs when building this on FreeBSD.

@ararslan ararslan added the compiler:codegen Generation of LLVM IR and native code label May 16, 2017
@ararslan ararslan requested a review from Keno May 16, 2017 19:03
@ararslan ararslan mentioned this pull request May 16, 2017
Merged
Keno
Keno approved these changes May 16, 2017
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuyichao yuyichao merged commit ab82ca4 into master May 16, 2017
@yuyichao yuyichao deleted the aa/llvm-eh-handler branch May 16, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuyichao yuyichao yuyichao approved these changes

@Keno Keno Keno approved these changes

Assignees

No one assigned

Labels

compiler:codegen Generation of LLVM IR and native code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ararslan @yuyichao @Keno