fix codegen bugs with llvm-gc-root pass #23114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures the return type of literal_pointer_val is always just a simple pointer, and always of the same type
vtjnash
added
compiler:codegen
Keno
reviewed
Aug 3, 2017
| jl_errorf("macro definition not allowed inside a local scope"); | ||
| name = literal_pointer_val(ctx, mn); | ||
| bnd = jl_get_binding_for_method_def(mod, (jl_sym_t*)mn); | ||
| JL_TRY { |
There was a problem hiding this comment.
julia> begin
for i = 1:1 end
macro g() end
end
ERROR: error compiling anonymous: macro definition not allowed inside a local scope
vs.
julia> begin
for i = 1:1 end
macro g() end
end
ERROR: macro definition not allowed inside a local scope
Stacktrace:
[1] macro expansion at ./REPL[1]:3 [inlined]
[2] anonymous at ./<missing>:?
Both results are wrong, but at least it now usually won't corrupt the C++ stack.
Keno
approved these changes
Aug 3, 2017
|
did this get put into #22984 accidentally? agreed on a test if possible, how'd you find this or what is it fixing? |
|
It wasn't accidental - the case that triggered my review and fixes here were from writing tests for that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensures the return type of literal_pointer_val is always just a simple pointer, and always of the same type (T_pjlvalue)