Skip to content

Conversation

@YingboMa
Copy link
Contributor

This PR fixes #21092.

@JeffBezanson
Copy link
Member

I think this should certainly work for big" " since that's used to input literal numbers, but I'm not sure it should work for parsing integers generally, since it's not really a standard syntax.

@YingboMa
Copy link
Contributor Author

YingboMa commented Dec 1, 2017

Ready for review.

@JeffBezanson JeffBezanson merged commit 255b5d5 into JuliaLang:master Dec 2, 2017
@JeffBezanson
Copy link
Member

Thanks.

I had forgotten that we actually also support _ in float literals, but that can be added later. The rules are subtler in that case, since _ must appear only between digits.

@YingboMa YingboMa deleted the myb/parse branch December 2, 2017 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

big_str macro doesn't support underscores

2 participants