Fixing #24214 #25285
Closed
Fixing #24214 #25285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change in string.jl JuliaLang#24214
Member
StefanKarpinski
left a comment
StefanKarpinski
left a comment
There was a problem hiding this comment.
Looks good, how about adding a test?
Test for JuliaLang#25285
Contributor
Author
|
Added a couple of tests. |
Member
|
There seems to be a whitespace error here, but it doesn't look like it was introduced by this PR. |
ararslan
reviewed
Dec 27, 2017
test/strings/basic.jl
Outdated
| @test isvalid(String, UInt8[0xfe, 0x80, 0x80, 0x80, 0x80, 0x80]) == false | ||
| # issue 24214, Check valid SubString | ||
| @test isvalid(SubString("teststring",1,5)) == true | ||
| @test isvalid(SubString(String(UInt8[0xfe, 0x80, 0x80, 0x80, 0x80, 0x80]), 1,2)) == false |
Member
There was a problem hiding this comment.
There's trailing whitespace on the end of this line
Whitespace error
Contributor
Author
|
I did not pay attention to it earlier, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a PR previously for this but after #24999 I felt that it would be better to do the changes again because some of the files changed in the previous PR were altered.
Fixes #24214.