[RFC] rename module_parent to enclosingmodule

[Sacha0]

Renaming module_parent to enclosingmodule came up in a slack conversation between @malmaud, @JeffBezanson, and myself. This pull request explores that change. Thoughts? Best!

[StefanKarpinski]

At least module_parent matches module_name though.

[Sacha0]

At least module_parent matches module_name though.

I had the same reaction when I saw module_parent next to module_name :). Perhaps if module_parent changes, module_name should change as well? The docstring reads

  module_name(m::Module) -> Symbol

  Get the name of a Module as a Symbol.

  Examples
  ≡≡≡≡≡≡≡≡≡≡

  julia> module_name(Base.LinAlg)
  :LinAlg

which almost seems like a method of the Symbol constructor apart from the qualification-drop? Best!

[martinholters]

almost seems like a method of the Symbol constructor apart from the qualification-drop

Indeed,

julia> Symbol(Base.LinAlg)
Symbol("Base.LinAlg")

does not look useful, does it? Should we just change that?

[Sacha0]

Status quo it is :). Thanks all!