Remove type assertion hack in mapreduce for skipmissing #28035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Member
Author
|
Mmm, it doesn't look like we can get rid of it yet @vtjnash. |
Member
|
Hm, seemed like it fixed the reduced case. Might need to remove simd annotation too? |
Member
|
Probably also needs #24129. But let me know if that doesn't fix it. |
No longer needed since 25f91ab.
Member
Author
|
Trying again now that #24129 has been merged. @nanosoldier |
Collaborator
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
Member
Author
|
Looks good now! The apparent regressions and improvements are unrelated. I'll merge in a while. |
Member
|
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer needed since #27945.
@nanosoldier
runbenchmarks("union", vs=":master")