fix reinterpret(Char, ::UInt32) for "unnatural" values (fix #29181) #29192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
force-pushed
the
sk/char-reinterpret
branch
from
87083bb to
3759d23
Compare
src/datatype.c
Outdated
| jl_ptls_t ptls = jl_get_ptls_states(); | ||
| if (0 < (int32_t)x) | ||
| return boxed_char_cache[x >> 24]; | ||
| uint32_t u = __builtin_bswap32(x); |
There was a problem hiding this comment.
We have bswap_32 defined for this for a few platforms.
There was a problem hiding this comment.
bswap_32 is the correct version since it takes care of the difference between clang, ICC, MSVC, or not having the builtin available at all.
see
Lines 32 to 57 in 7507511
StefanKarpinski
force-pushed
the
sk/char-reinterpret
branch
from
3759d23 to
0a18ca9
Compare
This code was assuming that character values only have bit-patterns that decoding a string can produce, but of course `reinterpret` can produce any bit pattern in a `Char` whatsoever. The fix doesn't use that assumption and only uses the cache for actual ASCII characters.
StefanKarpinski
force-pushed
the
sk/char-reinterpret
branch
from
0a18ca9 to
7d3fdcd
Compare
|
We're seeing a lot of httpbin flakiness again. Time to switch, @staticfloat? |
|
@StefanKarpinski your wish is my command: #29228 |
KristofferC
pushed a commit
that referenced
this pull request
Oct 6, 2018
…29192) This code was assuming that character values only have bit-patterns that decoding a string can produce, but of course `reinterpret` can produce any bit pattern in a `Char` whatsoever. The fix doesn't use that assumption and only uses the cache for actual ASCII characters. (cherry picked from commit 88f74b7)
KristofferC
pushed a commit
that referenced
this pull request
Oct 10, 2018
…29192) This code was assuming that character values only have bit-patterns that decoding a string can produce, but of course `reinterpret` can produce any bit pattern in a `Char` whatsoever. The fix doesn't use that assumption and only uses the cache for actual ASCII characters. (cherry picked from commit 88f74b7)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
…29192) This code was assuming that character values only have bit-patterns that decoding a string can produce, but of course `reinterpret` can produce any bit pattern in a `Char` whatsoever. The fix doesn't use that assumption and only uses the cache for actual ASCII characters. (cherry picked from commit 88f74b7)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
…29192) This code was assuming that character values only have bit-patterns that decoding a string can produce, but of course `reinterpret` can produce any bit pattern in a `Char` whatsoever. The fix doesn't use that assumption and only uses the cache for actual ASCII characters. (cherry picked from commit 88f74b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.