always obey inline declarations if the calling signature is concrete #29258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the suggestion in #27857 (comment)
JeffBezanson
added
performance
|
It indeed fixes JuliaArrays/StaticArrays.jl#494. Awesome! |
Keno
approved these changes
Sep 18, 2018
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
Nice! |
JeffBezanson
removed
the
needs nanosoldier run
|
Are the many regressions places to remove inlines or just noise? |
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2018
…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)
NHDaly
added a commit
to NHDaly/julia
that referenced
this pull request
Jan 17, 2019
…oncrete (JuliaLang#29258)" This reverts commit 2f9e279.
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
…29258) This implements the suggestion in #27857 (comment) (cherry picked from commit 8d6c1ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion in
#27857 (comment)
Will hopefully help e.g. JuliaArrays/StaticArrays.jl#494