Changed one identifier in one example #29279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes.
fredrikekre
approved these changes
Sep 20, 2018
fredrikekre
added
docs
KristofferC
pushed a commit
that referenced
this pull request
Sep 30, 2018
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes. (cherry picked from commit 6354405)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes. (cherry picked from commit 6354405)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
The example used identifier `x` for two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes. (cherry picked from commit 6354405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example used identifier
xfor two different purposes. While this isn't a problem for Julia, it makes humans have to read much more carefully. For examples I think it is much clearer to use different identifiers for different purposes.