Two small build system improvements #29486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use this setting for linking curl, which itself needs to find libssh2 and mbedtls. However, while curl will indeed eventually be in the same directory as these two libraries, it is not during linking, causing link failures (unless we happen to have global copies of the same libraries that the linker can pick up). Add an rpath-link command with the absolute path to our library directory to make sure the dependent libraries get picked up at link time.
These fail to build if mbedtls is not available in the global linker search path. Add a simple flag to disable them, since we don't use them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while trying to bootstrap Julia (x86_64 linux only) under BinaryBuilder, which doesn't have any global copies of our dependencies (as most linux distros do).