Skip to content

propgate inbounds to substring and use it in split #29557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2018
Merged

propgate inbounds to substring and use it in split #29557

merged 2 commits into from
Oct 16, 2018

Conversation

@KristofferC
Copy link
Member

Using it in split is mostly a proof of concept that the propagation works,

Before

julia> @btime split("str,str,str,str,str,str,str", ",")
  745.398 ns (10 allocations: 432 bytes)

After

julia> @btime split("str,str,str,str,str,str,str", ",")
  662.151 ns (10 allocations: 432 bytes)

Ref #26818

@KristofferC KristofferC added performance Must go faster strings "Strings!" labels Oct 7, 2018
@KristofferC KristofferC merged commit 18b9fc2 into master Oct 16, 2018
@StefanKarpinski StefanKarpinski deleted the kc/inb_subs branch October 16, 2018 14:56
@KristofferC KristofferC mentioned this pull request Oct 16, 2018
Closed
KristofferC added a commit that referenced this pull request Oct 29, 2018
@KristofferC
propgate inbounds to substring and use it in split (#29557)
1e86e2a 
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
@KristofferC KristofferC mentioned this pull request Oct 29, 2018
Merged
KristofferC added a commit that referenced this pull request Oct 31, 2018
@KristofferC
propgate inbounds to substring and use it in split (#29557)
41c2498 
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Nov 2, 2018
@KristofferC
propgate inbounds to substring and use it in split (#29557)
13b3983 
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Feb 11, 2019
@KristofferC
propgate inbounds to substring and use it in split (#29557)
2f62797 
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
KristofferC added a commit that referenced this pull request Feb 20, 2020
@KristofferC
propgate inbounds to substring and use it in split (#29557)
fd558e4 
* propgate inbounds to substring and use it in split

* remove Base prefix

(cherry picked from commit 18b9fc2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees

No one assigned

Labels

performance Must go faster strings "Strings!"

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KristofferC @StefanKarpinski