Skip to content

fix #29711: triu! for m > n #29712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2018
Merged

fix #29711: triu! for m > n #29712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f522114
triu M>N case bugfix
GiggleLiu Oct 18, 2018
5946934
fix a typo
GiggleLiu Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stdlib/LinearAlgebra/src/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ julia> triu!(M, 1)
function triu!(M::AbstractMatrix, k::Integer)
@assert !has_offset_axes(M)
m, n = size(M)
for j in 1:min(n, n + k)
for j in 1:min(n, m + k)
for i in max(1, j - k + 1):m
M[i,j] = zero(M[i,j])
end
Expand Down
12 changes: 12 additions & 0 deletions stdlib/LinearAlgebra/test/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,18 @@ end # for eltya
end
end

@testset "triu M > N case bug fix" begin
mat=[1 2;
3 4;
5 6;
7 8]
res=[1 2;
3 4;
0 6;
0 0]
@test triu(mat, -1) == res
end

@testset "Tests norms" begin
nnorm = 10
mmat = 10
Expand Down