Skip to content

Conversation

@vtjnash
Copy link
Member

@vtjnash vtjnash commented Oct 29, 2018

fix #29836

(reviewer note: this is two NFC commits to make the code a bit more consistent + the fix itself)

This was broken when `findfirst` was deprecated in 9bdf07f.
To make accessing them for testing less awkward.
Oops.

fixes #29836, and adds explicit test coverage
@thautwarm
Copy link
Member

nice!

@thautwarm
Copy link
Member

Hi, when will this be released? I mean the release with this bugfix.
Have to be a bit curious, for tesing my package depends on it.

@KristofferC
Copy link
Member

Good to go?

@Keno Keno merged commit 3a43157 into master Oct 31, 2018
@martinholters martinholters deleted the jn/29836 branch October 31, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

true === nothing when expanding macro.

4 participants