fix bug with max_values in union! #30315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
collections
rfourquet
force-pushed
the
rf/union-fix-max_values
branch
from
c796054 to
6a904e8
Compare
nalimilan
reviewed
Dec 9, 2018
| # saturated addition to prevent overflow with typemax(Int) | ||
| max_values(T::Union) = max(max_values(T.a), max_values(T.b), max_values(T.a) + max_values(T.b)) | ||
| max_values(::Type{Bool}) = 2 | ||
| max_values(::Type{Nothing}) = 1 |
There was a problem hiding this comment.
Could this be applied to all singleton types? You can check whether a type is a singleton using isdefined(T, :instance) (there's an issingletontype helper function for this in replace.jl).
There was a problem hiding this comment.
Yes seems like a good idea!
As CI is green and I think this is an urgent fix to have, I will merge as-is later today and implement your idea (which is not directly related to the bugfix) separately.
KristofferC
pushed a commit
that referenced
this pull request
Dec 12, 2018
(cherry picked from commit f49cb42)
KristofferC
pushed a commit
that referenced
this pull request
Dec 30, 2018
(cherry picked from commit f49cb42)
StefanKarpinski
added
triage
JeffBezanson
removed
triage
KristofferC
pushed a commit
that referenced
this pull request
Feb 4, 2019
(cherry picked from commit f49cb42)
KristofferC
pushed a commit
that referenced
this pull request
Feb 11, 2019
(cherry picked from commit f49cb42)
KristofferC
pushed a commit
that referenced
this pull request
Apr 20, 2019
(cherry picked from commit f49cb42)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
(cherry picked from commit f49cb42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
union!leading to currently havingSet([nothing, true, false])having only two elements :(