Skip to content

fix #31686, segfault on invalid cmdline option #31689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

fix #31686, segfault on invalid cmdline option #31689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,9 @@ static void jl_close_item_atexit(uv_handle_t *handle)

JL_DLLEXPORT void jl_atexit_hook(int exitcode)
{
if (jl_all_tls_states == NULL)
return;

jl_ptls_t ptls = jl_get_ptls_states();

if (exitcode == 0)
Expand Down
5 changes: 4 additions & 1 deletion test/cmdlineargs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,10 @@ let exename = `$(Base.julia_cmd()) --startup-file=no`
# --procs
@test readchomp(`$exename -q -p 2 -e "println(nworkers())"`) == "2"
@test !success(`$exename -p 0`)
@test !success(`$exename --procs=1.0`)
let p = run(`$exename --procs=1.0`, wait=false)
wait(p)
@test p.exitcode == 1 && p.termsignal == 0
end

# --machine-file
# this does not check that machine file works,
Expand Down