Prevent stack overflow in Profile #31893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a follow up to #31693, this fixes the other place in Profile that recurses over Profile data, causing stack overflows. This should fix a bunch of the recent intermittent CI faults on linux32.
vtjnash
previously requested changes
May 1, 2019
stdlib/Profile/src/Profile.jl
Outdated
| println(io, isempty(str) ? "$count unknown stackframe" : str) | ||
| noisefloor_down = fmt.noisefloor > 0 ? floor(Int, fmt.noisefloor * sqrt(count)) : 0 | ||
| tree(io, down, level + 1, cols, fmt, noisefloor_down) | ||
| worklist = Tuple{StackFrameTree, Int, Int, Union{String, Nothing}}[ |
There was a problem hiding this comment.
Suggested change
| worklist = Tuple{StackFrameTree, Int, Int, Union{String, Nothing}}[ | |
| worklist = [(bt, level, noisefloor, "")] |
No sense in reducing performance and introducing pointless complexity.
But I don't think this translation is correct: it doesn't seem expected that str would suddenly get appended to the worklist, when it wasn't there before the translation. It looks like this would print all level 0 items, followed by all level 1 items, followed by all level 2 items, and so on. (indeed, running this PR on @profile peakflops(), that's exactly the behavior that I see happen)
|
Thanks for the fixup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #31693, this fixes the other place in Profile
that recurses over Profile data, causing stack overflows. This
should fix a bunch of the recent intermittent CI faults on linux32.