Skip to content

Remove copy(::SubArray) definition from SparseArrays, fixes #32213. #32266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

Remove copy(::SubArray) definition from SparseArrays, fixes #32213. #32266

merged 1 commit into from
Jun 9, 2019

Conversation

@fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Jun 8, 2019 •
edited
Loading

xref #32249 (comment), alternative to #32249.

This method was introduced in #30552, but was unrelated to the rest of
the changes, and no-one reviewed or thought about the implications.

@fredrikekre fredrikekre mentioned this pull request Jun 8, 2019
Closed
@fredrikekre
Remove copy(::SubArray) definition from SparseArrays, fixes #32213.
9ca03be 
This method was introduced in #30552, but was unrelated to the rest of
the changes, and no-one reviewed or though about the implications.
@fredrikekre fredrikekre requested a review from KristofferC June 9, 2019 12:33
@KristofferC KristofferC merged commit 5d02c59 into master Jun 9, 2019
@KristofferC KristofferC mentioned this pull request Jun 9, 2019
Closed
@KristofferC KristofferC deleted the fe/fix32213 branch June 9, 2019 13:25
KristofferC pushed a commit that referenced this pull request Jun 9, 2019
@fredrikekre @KristofferC
Remove copy(::SubArray) definition from SparseArrays, fixes #32213. (#…
12fd2de 
…32266)

This method was introduced in #30552, but was unrelated to the rest of
the changes, and no-one reviewed or though about the implications.

(cherry picked from commit 5d02c59)
@KristofferC KristofferC mentioned this pull request Jun 9, 2019
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees

No one assigned

Labels

sparse Sparse arrays

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fredrikekre @KristofferC