Skip to content

Document the pass-through specialization heuristic for Type, Vararg, and Function #32817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2019
Merged

Document the pass-through specialization heuristic for Type, Vararg, and Function #32817

merged 2 commits into from
Oct 30, 2019

Conversation

@iamed2
Copy link
Contributor

@iamed2 iamed2 commented Aug 7, 2019

Closes #32761

fredrikekre
fredrikekre reviewed Aug 7, 2019
View reviewed changes
@iamed2 iamed2 force-pushed the ed/doc-specialization-tip branch from fad18d7 to 5f52092 Compare August 7, 2019 21:29
tkf
tkf reviewed Aug 8, 2019
View reviewed changes
@NHDaly NHDaly mentioned this pull request Aug 8, 2019
Open
nickrobinson251
nickrobinson251 reviewed Aug 9, 2019
View reviewed changes
@DilumAluthge DilumAluthge mentioned this pull request Sep 3, 2019
Closed
@timholy timholy merged commit 42e9490 into JuliaLang:master Oct 30, 2019
@iamed2
Copy link
Contributor Author

iamed2 commented Oct 30, 2019

Thanks Tim!

@iamed2 iamed2 deleted the ed/doc-specialization-tip branch October 30, 2019 21:45
@jebej
Copy link
Contributor

jebej commented Oct 30, 2019

I am confused as to what "using" an argument (a type in particular) means here.

In the first example f_type and g_type, to me the type is "used", and it definitely has a performance impact.

@cafaxo cafaxo mentioned this pull request Nov 29, 2019
Open
@thofma thofma mentioned this pull request Apr 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

@timholy timholy timholy approved these changes

+2 more reviewers

@tkf tkf tkf left review comments

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@JeffBezanson JeffBezanson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vararg vs "..." slurping has huge performance impacts which defy analysis

8 participants

@iamed2 @jebej @tkf @timholy @fredrikekre @nickrobinson251 @StefanKarpinski @JeffBezanson